-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix up CI, improve typing, remove dead imports, and other minor changes #248
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the linting
Should be done |
i look into the rest tomorrow. The vulnerabilities shouldn't affect us. |
Anything left to do here on my side? |
i guess not but i can't test it at the moment because i have no time. |
Any chance you could find the time for this, or at least make a release with the current master? I am also down to spend a bit of time to fix potential issues my changes cause, although I do not believe there should be any. |
Bump version to 4.4.0 (hope that follows your versioning schemes, did it since I was already touching it up anyway)
Fix up CI using deprecated actions - not 100% sure if those will run now (since they require approval), but fingers crossed, so far never had trouble upgrading through a simple version bump. Should hopefully get rid of the failing CI linter, or at least of the node version warnings in the CI if not that.
Fix up Python versions in setup.py to use currently supported versions by upstream.
Fix broken typing in function parameters.
Add py.typed and tag the packages as supporting typing, to allow tools use the type hints that there are already even though the package is not fully typed yet - https://typing.readthedocs.io/en/latest/spec/distributing.html#packaging-typed-libraries
Remove outdated List, Union and Optional typing imports.
Remove unused imports.
Remove nonexistent win64 platform check - https://docs.python.org/3/library/sys.html#sys.platform
Tagging a new release would be welcome after this is pulled.