12 aggregate scheme #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trange plot with a supplementary checkbox to control whether the min/max are based on extremes or averages of the min/max values.
… and creates an aggregate summary view of all the schemes (except the focal one) and appends this with the scheme name of 'Summary' then adds textual blue colour coding. Also additional code to enable/disable the 'summary full range' depending on whether a summary view has been selected
Merged
matt-dray
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
This is a neat solution! I like the ability to switch from mean lo/hi to the full range. The toggle may be preferable to checkboxes in general; maybe we can review this when we review the UI later down the road.
I've marked this as 'approve' but I think it would be worth incorporating the two suggestions I've made; just to make even clearer that the summary is composed of selected schemes.
|
...although the relationship between the blue toggle and the blue summary markers would be lost if we used more toggles and fewer checkboxes, of course. |
Co-authored-by: Matt Dray <18232097+matt-dray@users.noreply.github.com>
Co-authored-by: Matt Dray <18232097+matt-dray@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12
Adds the ability to view an aggregate summary of schemes' responses (except the focal one) within the pointrange plot.
How to use:
This view is toggle-able from the point-range settings sidebar.
The slide switch enables/disables the aggregate view and the checkbox controls whether the min/max are based on extreme values or the average (mean).
When enabled the aggregate summary is displayed as a new scheme called 'Summary 🔵' at the end of the list of schemes and the pointrange is coloured blue.
Integration with existing functionality
✅ NEE range
The 'Summary 🔵' is associated with the relevant nee values for each mitigator so can be used in combination with the 'Show NEE range?' toggle.
This gives a view whether the schemes are collectively within the NEE range.
✅ Facet by scheme
Faceting by scheme results in the 'Summary 🔵' aggregate with its own facet so overall settings per mitigator can be quickly scanned:
✅ Standardise by horizon length
The 'Summary 🔵' view is responsive to the standardise by horizon length setting.
✅ Show mitigator codes
The 'Summary 🔵' is unaffected by showing mitigator codes or names.