-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
84 pointrange xaxis #89
Conversation
…trange plot with a supplementary checkbox to control whether the min/max are based on extremes or averages of the min/max values.
… and creates an aggregate summary view of all the schemes (except the focal one) and appends this with the scheme name of 'Summary' then adds textual blue colour coding. Also additional code to enable/disable the 'summary full range' depending on whether a summary view has been selected
… breaks on 0.01 (1%) intervals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
I think for this PR you may have branched off of the 12_aggregate_scheme branch rather than main (some of the commits in this PR look suspiciously like summary-related commits!). Not the end of the world if so, would just mean it would make logical sense to merge the 12_aggregate_scheme branch first (in #88) before this one.
But, before that, I noticed that there might only be 1 tick, or no ticks, on the x-axis in certain situations, like:
We probably need two or more ticks per chart, do you reckon? So people can get an idea of the plotted values.
…n standardised by horizon length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, this appears to work after testing with a few combinations of schemes and mitigators.
closes #84
adds an internal function to set breaks at 1 percentage point for pointrange plots when standardised by horizon length.
Now the x-axis is labelled with breaks that do not repeat themselves within each facet: