Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

84 pointrange xaxis #89

Merged
merged 6 commits into from
Nov 4, 2024
Merged

84 pointrange xaxis #89

merged 6 commits into from
Nov 4, 2024

Conversation

craig-parylo
Copy link
Contributor

closes #84

adds an internal function to set breaks at 1 percentage point for pointrange plots when standardised by horizon length.

Now the x-axis is labelled with breaks that do not repeat themselves within each facet:

image

…trange plot with a supplementary checkbox to control whether the min/max are based on extremes or averages of the min/max values.
… and creates an aggregate summary view of all the schemes (except the focal one) and appends this with the scheme name of 'Summary' then adds textual blue colour coding. Also additional code to enable/disable the 'summary full range' depending on whether a summary view has been selected
@craig-parylo craig-parylo self-assigned this Nov 1, 2024
@matt-dray matt-dray added this to the v0.4.0 milestone Nov 1, 2024
@matt-dray matt-dray added bug Something isn't working must MoSCoW priority labels Nov 1, 2024
Copy link
Contributor

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

I think for this PR you may have branched off of the 12_aggregate_scheme branch rather than main (some of the commits in this PR look suspiciously like summary-related commits!). Not the end of the world if so, would just mean it would make logical sense to merge the 12_aggregate_scheme branch first (in #88) before this one.

But, before that, I noticed that there might only be 1 tick, or no ticks, on the x-axis in certain situations, like:

image

We probably need two or more ticks per chart, do you reckon? So people can get an idea of the plotted values.

@craig-parylo
Copy link
Contributor Author

I've adjusted the scale_x_continuous() settings for pointrange plots when standardised by horizon length. Each facet should now have around 3 breaks visible:
image

Note there are cases where some facets are shown to the nearest percentage point with others showing breaks with up to 2pd accuracy, which may look strange at first glance.

Copy link
Contributor

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, this appears to work after testing with a few combinations of schemes and mitigators.

@craig-parylo craig-parylo merged commit e3c6f26 into main Nov 4, 2024
@craig-parylo craig-parylo deleted the 84_pointrange_xaxis branch November 4, 2024 10:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working must MoSCoW priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point-range x-axis may show duplicate values when standardised by horizon
2 participants