Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

🌐 Updated Bulgarian translations #22097

Merged
merged 1 commit into from
Feb 7, 2025
Merged

🌐 Updated Bulgarian translations #22097

merged 1 commit into from
Feb 7, 2025

Conversation

yovko
Copy link
Contributor

@yovko yovko commented Jan 31, 2025

Updates for bg/portal.json & bg/search.json

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2025 •
edited
Loading

Walkthrough

This pull request focuses on improving the Bulgarian localization in the Ghost project. The changes primarily involve updating translations in the portal.json and search.json files located in the ghost/i18n/locales/bg/ directory. The modifications include translating previously empty strings, updating specific email addresses, and ensuring more complete localization for Bulgarian users.

Changes

File Changes
ghost/i18n/locales/bg/portal.json - Updated email from "petrov@example.com" to "angel@example.com"
- Added Bulgarian translation for "#s from this email domain are currently restricted"
- Added Bulgarian translation for "This site only accepts paid members"
- Translated "Too many sign-up attempts, try again later"
ghost/i18n/locales/bg/search.json - Reformatted "No matches found" line without changing its content

Possibly related PRs

Suggested labels

affects:i18n

Suggested reviewers

  • cathysarisky
  • cathysarisky
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4b8c72 and 0fdb71f.

📒 Files selected for processing (2)
  • ghost/i18n/locales/bg/portal.json (5 hunks)
  • ghost/i18n/locales/bg/search.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • ghost/i18n/locales/bg/search.json
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: Unit tests (Node 20.11.1)
  • GitHub Check: Unit tests (Node 18.12.1)
  • GitHub Check: Regression tests (Node 20.11.1, sqlite3)
  • GitHub Check: Regression tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 20.11.1, sqlite3)
  • GitHub Check: Lint
  • GitHub Check: Database tests (Node 20.11.1, mysql8)
  • GitHub Check: i18n
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Database tests (Node 18.12.1, mysql8)
🔇 Additional comments (4)
ghost/i18n/locales/bg/portal.json (4)

101-101: LGTM! Example data localized appropriately.

The email address change from "jamie@example.com" to "angel@example.com" maintains consistency with the localized name "Ангел Петров" above it, making the example data more relevant for Bulgarian users.

141-141: LGTM! Clear and accurate translation.

The Bulgarian translation "Регистрациите от този домейн в момента са ограничени." accurately conveys the meaning of "#s from this email domain are currently restricted." while maintaining natural language flow.

171-171: LGTM! Precise and natural translation.

The Bulgarian translation "Този сайт приема само платени потребители." accurately conveys the meaning of "This site only accepts paid members." while maintaining natural language flow.

180-180: LGTM! Clear error message translation.

The Bulgarian translation "Твърде много опити за регистрация, опитайте пак по-късно" accurately conveys the meaning of "Too many sign-up attempts, try again later" while maintaining natural language flow.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cathysarisky
Copy link
Contributor

Hey @coderabbitai, you should always review the translations unless the right side (value) of the key-value pair is blank. Skipping search.json was inappropriate. Language changes should be reviewed.

@cathysarisky
Copy link
Contributor

Thank you @yovko for your contribution! LGTM.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2025

🧩 Analysis chain

@cathysarisky Thank you for the guidance. You're absolutely right. I apologize for inappropriately skipping the review of search.json. I will review all translation changes thoroughly unless the value is blank.

🏁 Script executed:

#!/bin/bash
# Get the content of search.json
cat ghost/i18n/locales/bg/search.json

Length of output: 312

✏️ Learnings added 
Learnt from: cathysarisky
URL: https://github.com/TryGhost/Ghost/pull/22097

Timestamp: 2025-02-07T18:07:33.962Z
Learning: Always review translation changes in language files unless the right side (value) of the key-value pair is blank. This includes reviewing both the correctness and appropriateness of the translations.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@9larsons 9larsons merged commit 0da164b into TryGhost:main Feb 7, 2025
22 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 21, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cathysarisky cathysarisky cathysarisky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yovko @cathysarisky @9larsons