-
-
Notifications
You must be signed in to change notification settings - Fork 831
bump node-gyp to v10 #1788
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bump node-gyp to v10 #1788
Conversation
Hey there, I am curious. What kind of tests have run to verify the version bump is not creating other issues, regressions, etc. ? |
Can confirm this solves the issue, builds, and works at least for basic database operations. Tested with |
I wonder if this might also fix #1762, since the deprecated dependency is coming in courtesy of node-gyp. |
This would also fix GHSA-2p57-rm9w-gvfp. All dependencies are fixed down the line. Current dependency chain to affected package: |
I compiled this branch, and then updated n8n to use @daniellockyer Can we please have this merged 🙏🏽 |
Is it possible to get this merged? |
@daniellockyer what is the reason for closing this PR? Has the issue been solved differently? |
Sorry no, the PR was automatically closed with a branch change 🫤 This PR is blocked because it would bump our Node requirement, which we can't do without a major |
I see, would it be possible to release a new major version then? This impacts distributions which build packages from source (such as Homebrew), and |
Trying this again in #1834 |
Fixes #1752