Skip to content

bump node-gyp to v10 #1788

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

branchvincent
Copy link

Fixes #1752

@YasharF
Copy link

YasharF commented May 26, 2024

Hey there, I am curious. What kind of tests have run to verify the version bump is not creating other issues, regressions, etc. ?

@niklasf
Copy link

niklasf commented Jun 6, 2024

Can confirm this solves the issue, builds, and works at least for basic database operations. Tested with --target_arch arm --build-from-source.

@demiankatz
Copy link

I wonder if this might also fix #1762, since the deprecated dependency is coming in courtesy of node-gyp.

@gladykov
Copy link

gladykov commented Jul 2, 2024

This would also fix GHSA-2p57-rm9w-gvfp. All dependencies are fixed down the line.

Current dependency chain to affected package:

image

@netroy
Copy link

netroy commented Jul 8, 2024

I compiled this branch, and then updated n8n to use file: versions of sqlite3, and all integration tests still passed.
Considering that n8n's backend tests do a lot of database calls, I don't think there is going to be any major regression caused by this upgrade.
The upgrade also cleaned up the dependency tree a little bit as a side-bonus 🎉 .

@daniellockyer Can we please have this merged 🙏🏽

@DamienCassou
Copy link

Is it possible to get this merged?

@daniellockyer daniellockyer deleted the branch TryGhost:main April 30, 2025 10:18
@DamienCassou
Copy link

@daniellockyer what is the reason for closing this PR? Has the issue been solved differently?

@daniellockyer
Copy link
Contributor

Sorry no, the PR was automatically closed with a branch change 🫤 This PR is blocked because it would bump our Node requirement, which we can't do without a major

@branchvincent
Copy link
Author

I see, would it be possible to release a new major version then? This impacts distributions which build packages from source (such as Homebrew), and sqlite3 is a common dependency of many node packages

@branchvincent
Copy link
Author

Trying this again in #1834

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install sqlite3 fail if prebuilt unreachable and Python v3.12 is installed
8 participants