-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Both column headings for the basic mobile layouts should have the same formatting (bold etc.) #193
Comments
This is tricky to implement with the current format of the layouts. Consider the VAI layout file:
or the VTA layout file:
To denote that something is a title, we surround the column in This ambiguity means we need to make the layout parser attempt to guess our intention. Right now, there are already some heuristics of when it decides that I'm worried that with more heuristics trying to interpret ambiguous data, we'll make a very brittle layout parser that doesn't always do what we want. We already have this situation on our hands! Before I add more heuristics to the layout parser, I want to see if we can make a format where
are all explicitly labelled. Antti: do you have any thoughts about such a format? |
@aarppe: update, I've come up with a TSV format that might work for us: https://docs.google.com/spreadsheets/d/1opkulWHTWOzQRRBpkVVc24nY7v508VCcIZgN-z06ryQ/edit?usp=sharing This is what it looks like as a text file: * Something is happening now
_ Actor _ ni-/ki- word
> I → you (one) . Ind+Prs+1Sg+2SgO
> I → him/her . Ind+Prs+1Sg+3SgO
# Explanation
# Each cell starts with a character and a space
# Each character defines what kind of cell it is
# Cell types:
# * is a title cell: this is a big title that labels the entire next paragraph
# _ is a column heading: this gives a label to the rest of the column
# > is a row label: this labels the data to the right of it in the row
# # is a comment. Comments are ignored until the end of the line
# Empty lines denote a separation between panes
# multiple empty lines are treated as one empty line |
Bumping. @aarppe, please have a look at my proposal. I'd like to hear your
opinion on this.
El vie., 13 de dic. de 2019 02:41, aarppe <notifications@github.com>
escribió:
… Following up on the implementation of the new mobile basic layouts in #191
<#191>,
for the sake of clarity, both column headings for the four types of verbs
should be formatted similarly (bold-faced, etc.), not just *'ni-/ki-
word'* and *'ê-/kâ- word'* as in below ...
[image: image]
<https://user-images.githubusercontent.com/15003407/70790208-47ce6100-1d9d-11ea-8c5a-7e756ed89dfa.png>
[image: image]
<https://user-images.githubusercontent.com/15003407/70789974-bc54d000-1d9c-11ea-8376-7d3a0b67022b.png>
... but also *'Actor'* and *'Actor -> Goal'*
This applies only to the mobile basic layouts for the four verb types, not
the nouns.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#193>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARQE7PFN772PGSGMM6UNPDQYNKD5ANCNFSM4J2KNC2A>
.
|
Yes, looks good, and I think this achieves what we need for the current layouts, as well as has the information that would be needed for the more complex, multipane ones. A few observations/questions/comments, which need not necessarily hold back development right now:
|
I like this suggestion! Let's incorporate it! * Something is happening now
^ Actor ^ ni-/ki- word
> I → you (one) . Ind+Prs+1Sg+2SgO
> I → him/her . Ind+Prs+1Sg+3SgO
No. Every cell must have a marker as its first character. This is mostly to make my life as a programmer easier, and to make EVERYTHING explicit.
Everything up to the tab character is part of the label. The intention is to edit it in a spreadsheet program, so naturally, everything in the cell in the spreadsheet will be part of the cell! No need to quote or anything!
I haven't decided on how to implement that. I also think it's not a good idea, as "justification" is a presentational concern, whereas I want to keep the layout format "semantic"; The label's role in the layout (e.g., whether it is a column label, row label, or panel heading) should determine its presentation, in my opinion.
We could implement this... but again, I prefer things being explicit. Let's cross the pane bridge later :)
The latter! I'd prefer those translations be defined and managed elsewhere. That way, we can share translations. See how the TSV file is rendered here: https://gist.github.com/eddieantonio/9eeba1af89ab683406c38b3945adfe89 |
No other comments (i.e. I am in agreement), other than the following clarifications: Re: 2 - so is the period Re: 5-6 - but, how the layouts would now be defined seems to me very much amenable to how I've thought the panes would work. That is, your proposed specification would work to my mind not just for defining the static layouts, but could just as well be interpreted as consisting of a set of pane-wise definitions, in particular if the layout consists of single column panes sharing the same title label (perhaps with some further detail in the title label to make some things explicit), that the software layout logic could then organize as best fits the screen (in terms of one or more columns). Re: 7 - yes, I do not want to enumerate all the translations over and over again, so one central specification file (or perhaps per P-O-S to avoid ambiguity) is most desirable. |
Yep! I just forgot to mark it as such in the documentation; I shall amend it.
I agree! I just want to implement one small thing (explicit layouts) first before jumping to the bigger thing (explicit layouts with panes).
👍 |
The comments here go beyond the original issue. We need a new issue to define and implement the layout format following the sketch above. This is done in #167. |
Following up on the implementation of the new mobile basic layouts in #191, for the sake of clarity, both column headings for the four types of verbs should be formatted similarly (bold-faced, etc.), not just 'ni-/ki- word' and 'ê-/kâ- word' as in below ...
... but also 'Actor' and 'Actor -> Goal'
This applies only to the mobile basic layouts for the four verb types, not the nouns.
The text was updated successfully, but these errors were encountered: