-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Minor ux updates #536
Minor ux updates #536
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 73 73
Lines 2578 2578
=======================================
Hits 2330 2330
Misses 248 248
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I named this "UX updates" but what I meant was "admin-type-updates-that-the-user-doesn't-see" 🥴
All it does is remove the references to the SVG (external link icon) that no longer are used in the code. There was a bit of confusion around the SVG icon so it was replaced with text. As well, there was some JS that was left unused (see the error message here), so that's been removed as well. Finally, there's unused templates that are removed too.
(I was going to bundle the template into this PR but as I'm not sure if it'll be a huge change or not, I'll just make it part of the next one.)