Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor ux updates #536

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Minor ux updates #536

merged 3 commits into from
Aug 31, 2020

Conversation

kobexamoh
Copy link
Contributor

@kobexamoh kobexamoh commented Aug 30, 2020

I named this "UX updates" but what I meant was "admin-type-updates-that-the-user-doesn't-see" 🥴

All it does is remove the references to the SVG (external link icon) that no longer are used in the code. There was a bit of confusion around the SVG icon so it was replaced with text. As well, there was some JS that was left unused (see the error message here), so that's been removed as well. Finally, there's unused templates that are removed too.

(I was going to bundle the template into this PR but as I'm not sure if it'll be a huge change or not, I'll just make it part of the next one.)

@cypress
Copy link

cypress bot commented Aug 30, 2020



Test summary

87 0 7 0


Run details

Project cree-intelligent-dictionary
Status Passed
Commit 3b57229 ℹ️
Started Aug 30, 2020 7:47 PM
Ended Aug 30, 2020 7:50 PM
Duration 03:50 💡
OS Linux Ubuntu - 16.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2020

Codecov Report

Merging #536 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          73       73           
  Lines        2578     2578           
=======================================
  Hits         2330     2330           
  Misses        248      248           
Impacted Files Coverage Δ
CreeDictionary/CreeDictionary/urls.py 90.00% <ø> (ø)
CreeDictionary/DatabaseManager/__main__.py 77.41% <ø> (ø)
CreeDictionary/DatabaseManager/test_db_builder.py 37.93% <ø> (ø)
...tionary/DatabaseManager/xml_consistency_checker.py 100.00% <ø> (ø)
...CreeDictionary_tests/test_creedictionary_extras.py 100.00% <ø> (ø)
...tabaseManager_tests/xml_entry_lemma_finder_test.py 94.44% <ø> (ø)
...y/tests/DatabaseManager_tests/xml_importer_test.py 97.77% <ø> (ø)
...ctionary/tests/utils_tests/test_paradigm_filler.py 100.00% <ø> (ø)
CreeDictionary/utils/crkeng_xml_utils.py 86.89% <ø> (ø)
CreeDictionary/utils/fst_analysis_parser.py 93.57% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089679f...cf0741e. Read the comment docs.

Copy link
Member

@eddieantonio eddieantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobexamoh kobexamoh merged commit 9498d52 into master Aug 31, 2020
@kobexamoh kobexamoh deleted the minor-ux-updates branch August 31, 2020 18:40
@kobexamoh kobexamoh linked an issue Aug 31, 2020 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve presentation of multiple recordings
3 participants