Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor ux updates #536

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Minor ux updates #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aafb9a
Remove unused JS variable.
kobexamoh Aug 30, 2020
ea65f00
Remove unused templates from code.
kobexamoh Aug 30, 2020
cf0741e
Remove references to external link SVG from project.
kobexamoh Aug 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions CreeDictionary/CreeDictionary/templates/CreeDictionary/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,22 +39,6 @@
</button>
</template>

{# The speaker button template (multiple recordings) #}
<template id="template:recording-item">
<li class="recordings-list__item" data-cy="recordings-list__item">
<button class="audio-snippet">
<slot name="speaker-name"></slot>,
<slot name="speaker-dialect"></slot>
</button>
</template>

{# The speaker-bio links template #}
<template id="template:speaker-bio-link">
<a href="" target="_blank" rel="noopener" data-cy="recordings-list__item-speaker">Learn more about
<slot name="speaker-name"></slot>.
</a>
</template>


{% endspaceless %}

Expand Down
3 changes: 0 additions & 3 deletions CreeDictionary/CreeDictionary/templates/CreeDictionary/svg-sprites.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,4 @@
<symbol id="play-solid" viewBox="0 0 448 512">{% include './svg-sprites/play-solid.svg-path' %}</symbol>
</svg>

<svg aria-hidden="true" style="position: absolute; width: 0; height: 0;" version="1.1" xmlns="http://www.w3.org/2000/svg">
<symbol id="external-link-alt-solid" viewBox="0 0 512 512">{% include './svg-sprites/external-link-alt-solid.svg-path' %}</symbol>
</svg>
{% endspaceless %}
1 change: 0 additions & 1 deletion ...nary/CreeDictionary/templates/CreeDictionary/svg-sprites/external-link-alt-solid.svg-path
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/recordings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ export function retrieveListOfSpeakers() {
fetch(derivedURL)
.then(request => request.json())
.then(returnedData => {
let numberOfRecordings = returnedData.length // number of records on the server

// Unhide the explainer text
let recordingsHeading = document.querySelector('.definition__recordings--not-loaded')
recordingsHeading.classList.remove('definition__recordings--not-loaded')
Expand Down