dynamic near far #356
Merged
dynamic near far #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great @valentinMachado . Hapy to give a review to this PR. Can you just tell me how I can test this zoom behavior? |
|
@agrignard first you should pull this branch, then host the repo with a local server on your computer to run examples and test the zoom behavior. One way to do that is to follow "Running the examples" section of the Ud-Viz ReadMe then open localhost:8000 on your web browser. This will give you the possibility to test examples based on the code of this branch. |
|
OK great, the near far now work and we are able to zoom out without having the scene disappearing. I am personally find with this PR. I guess we let @EricBoix merge it? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #199