Fix bug with grid rows and breakpoints #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jernestmyers
force-pushed
the
style/fix-grid-layout-bug
branch
from
77f41cf to
0d095ec
Compare
dmfalke
approved these changes
Feb 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our breakpoints targeting the grid layout are off. On the live site, notice how changing between the workspace tabs for all datasets to new upload jumps the page:
Screen.Recording.2024-02-07.at.10.00.42.AM.mov
I reverted an old change I made to
default-layoutthat added the!importantattribute. It was a hack that masked other problems. Somehow it seems Ortho is using just the default layout grid, even on the homepage, without issue.As for genomics, I made specific changes to breakpoint logic that fixes the original issue that the
!importantattribute aimed to fix, which was the "ghost" effect of the hamburger menu rendering without the site header's background behind it, and it fixed the jumping effect that prompted this investigation. I also moved a breakpoint that is intended to target the homepage grid areas but was actually being applied sitewide.