Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix bug with grid rows and breakpoints #830

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix bug with grid rows and breakpoints #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d095ec
Fix bug with grid rows and breakpoints
jernestmyers Feb 6, 2024
0aa5163
Merge branch 'main' into style/fix-grid-layout-bug
jernestmyers Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/libs/web-common/src/styles/default-layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ body.vpdb-Body {
grid-template-rows: $expanded-header-height auto 1fr auto;

@media screen and (max-width: $hamburger-width) {
grid-template-rows: auto auto 1fr auto !important;
grid-template-rows: auto auto 1fr auto;
}

grid-template-columns: 100%;
Expand Down
15 changes: 0 additions & 15 deletions ...enomics-site/webapp/wdkCustomization/js/client/components/homepage/VEuPathDBHomePage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,18 +194,3 @@ body.vpdb-Body .ExternalContentController a[name]::before {
body.vpdb-Body .wdk-RecordSidebarContainer {
top: 2em;
}

body.vpdb-Body .vpdb-RootContainer {
@media screen and (max-width: $mobile-width) {
grid-template-areas:
'header'
'subheader'
'banner'
'nav'
'content'
'side'
'footer';

grid-template-rows: auto auto auto auto 1fr auto auto;
}
}
17 changes: 17 additions & 0 deletions packages/sites/genomics-site/webapp/wdkCustomization/js/client/styles/home-page-layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ body.vpdb-Body .vpdb-RootContainer {

grid-template-rows: 11em auto auto 1fr auto;

@media screen and (max-width: $hamburger-width) {
grid-template-rows: auto auto auto 1fr auto;
}

&__home {
grid-template-areas:
'header header header'
Expand All @@ -32,6 +36,19 @@ body.vpdb-Body .vpdb-RootContainer {
'nav side side'
'footer footer footer';
}

@media screen and (max-width: $mobile-width) {
grid-template-areas:
'header'
'subheader'
'banner'
'nav'
'content'
'side'
'footer';

grid-template-rows: auto auto auto auto 1fr auto auto;
}
}

&__home.vpdb-RootContainer__news-expanded {
Expand Down
Loading