Update player visibility when changing observer mode #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
C_BasePlayer::SetObserverModeto callUpdateVisibility()after updating the value ofm_iObserverMode. This is because the value ofm_iObserverModecan affect the visibility state calculated for the player (ex. the value ofm_hRender) whenUpdateVisibility()is called. Because this call is currently not made, a player's visibility state may reflect having a different observer mode than their current mode, which may cause visual discrepancies.This PR resolves #1160. In particular, this is because this change means that the client player is properly marked as not visible when their observer mode is set to
OBS_MODE_NONEupon spawning.