Use material design theme #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak splitpane dividers to be less intrusive
No more orphan dialogs improves UX on multi-monitor setups
|
Well, that's different. Not bad though. Is there a dark mode? Lol |
JLLeitschuh
reviewed
Apr 20, 2019
JLLeitschuh
reviewed
Apr 20, 2019
| @@ -9,7 +9,7 @@ | |||
| <?import javafx.scene.layout.HBox?> | |||
| <?import javafx.scene.layout.StackPane?> | |||
| <HBox styleClass="socket" | |||
| fx:controller="edu.wpi.grip.ui.OperationController" | |||
| fx:controller="edu.wpi.grip.ui.pipeline.OutputSocketController" | |||
There was a problem hiding this comment.
fx:controller is necessary, and OperationController is for controlling the UI element displaying an entire operation. OutputSocketController is more appropriate.
This also makes the file in line with InputSocket.fxml, which already uses InputSocketController as its fx:controller attribute
JLLeitschuh
approved these changes
Apr 20, 2019
Make undecorated instead of utility Put padding in CSS instead of FXML
|
No dark mode yet. Maybe later |
Makes it so that the default dialog size won't result in (small) scroll bars and text overruns.
Was caused by removing the stylesheet from MainWindow.fxml
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
============================================
- Coverage 52.89% 52.76% -0.13%
Complexity 1 1
============================================
Files 327 327
Lines 8852 8877 +25
Branches 560 561 +1
============================================
+ Hits 4682 4684 +2
- Misses 3966 3989 +23
Partials 204 204 |
Use a hard color border instead of a guassian shadow (which looked like a fuzzy border as well as undesirably shading the button icons)
|
@SamCarlberg can this be merged? |
JLLeitschuh
approved these changes
Aug 17, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #664
Makes dialogs appear centered on the main window, instead of centered on the primary screen (which was a problem on multi-monitor setups)
Screenshots
Empty window
Pipeline
Step detail
Palette
Analysis dialog
Deploy dialog
For reference only, since deploy is going to be removed
Exception alert
