Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run tests under wasmtime as part of the CI #144

Closed
wants to merge 1 commit into from
Closed

Run tests under wasmtime as part of the CI #144

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Jun 14, 2020

No description provided.

- name: "Run tests: wasmtime"
run: |
VERSION=v0.8.0
wget https://github.com/bytecodealliance/wasmtime/releases/download/v0.8.0/wasmtime-$VERSION-x86_64-linux.tar.xz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional $VERSION interpolation in url here

Base automatically changed from build_no_root to master June 16, 2020 00:55
As a followup I plan to add support for running under wabt too.
Base automatically changed from master to main January 19, 2021 23:27
kildom pushed a commit to kildom/clang-wasi-port that referenced this pull request Jul 14, 2021
This should probably have been part of WebAssembly#140 but we don't actually
support signals so this doesn't get much testing I imagine.

The old names like `__WASI_SIGBUS` no longer exist and the new names
look like `__WASI_SIGNAL_BUS`.
@TerrorJack
Copy link
Contributor

@sbc100 I have patches in my wasi-sdk fork that fix the tests and run them via wasmtime; if you don't mind, I'd like to open another PR to port my patches?

@sbc100
Copy link
Member Author

sbc100 commented Jan 2, 2023

@sbc100 I have patches in my wasi-sdk fork that fix the tests and run them via wasmtime; if you don't mind, I'd like to open another PR to port my patches?

Hmm.. this PR is 2.5 years old! Please feel free to replace it with something newer.

- name: "Run tests: wasmtime"
run: |
VERSION=v0.8.0
wget https://github.com/bytecodealliance/wasmtime/releases/download/v0.8.0/wasmtime-$VERSION-x86_64-linux.tar.xz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe join these commands with && so we don't continue if the previous one fails.

@TerrorJack
Copy link
Contributor

Shall we close this one given #278 has landed for some time?

@abrown abrown closed this Mar 17, 2023
alexcrichton pushed a commit to alexcrichton/wasi-sdk that referenced this pull request Apr 5, 2023
This brings in the following changes:

f645f49 Update signal macros after upgrade to snapshot1 (WebAssembly#144)
8b3266d github actions: pin checkout action to v1 (WebAssembly#145)
410c660 Use constructor functions for optional init routines. (WebAssembly#142)
fe13053 c header generation updated for reorganized witx ast (WebAssembly#139)
cd74e1d Correct the version of WebAssembly#136 on master (WebAssembly#141)
446cb3f Wasi snapshot preview1 (WebAssembly#140)
54102f0 Ignore rights in libpreopen. (WebAssembly#129)
8c9e1c6 Make the `__original_main` definition weak, fixing -flto. (WebAssembly#138)
cf81683 Optimize `fmin`, `fmax`, etc. (WebAssembly#120)
deb8eae Don't pre-check capabilities in `openat`. (WebAssembly#130)
ca9046d Use consistent style for wasi-libc C source files. (WebAssembly#131)
951cc3e Fix unintended recursion in __wasilibc_register_preopened_fd. (WebAssembly#133)
5216983 Avoid a `strdup` call in `__wasilibc_populate_libpreopen`. (WebAssembly#128)
70099d4 Don't link in libpreopen initialization code when it isn't needed. (WebAssembly#127)
ec4549d Temporarily disable the use of `__heap_base`. (WebAssembly#132)
a214f1c Use __heap_base by dlmalloc (WebAssembly#114)
a94d2d0 Avoid varargs conventions when calling open (WebAssembly#126)
7fcc4f2 Revamp and simplify the libpreopen code. (WebAssembly#110)
eb7230c Remove more unsupported headers. (WebAssembly#123)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants