Roll wasi-libc to include snapshot1 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
roll_wasi_libc
branch
from
f66651e to
c60488f
Compare
sbc100
changed the title
This brings in the following changes: f645f49 Update signal macros after upgrade to snapshot1 (#144) 8b3266d github actions: pin checkout action to v1 (#145) 410c660 Use constructor functions for optional init routines. (#142) fe13053 c header generation updated for reorganized witx ast (#139) cd74e1d Correct the version of #136 on master (#141) 446cb3f Wasi snapshot preview1 (#140) 54102f0 Ignore rights in libpreopen. (#129) 8c9e1c6 Make the `__original_main` definition weak, fixing -flto. (#138) cf81683 Optimize `fmin`, `fmax`, etc. (#120) deb8eae Don't pre-check capabilities in `openat`. (#130) ca9046d Use consistent style for wasi-libc C source files. (#131) 951cc3e Fix unintended recursion in __wasilibc_register_preopened_fd. (#133) 5216983 Avoid a `strdup` call in `__wasilibc_populate_libpreopen`. (#128) 70099d4 Don't link in libpreopen initialization code when it isn't needed. (#127) ec4549d Temporarily disable the use of `__heap_base`. (#132) a214f1c Use __heap_base by dlmalloc (#114) a94d2d0 Avoid varargs conventions when calling open (#126) 7fcc4f2 Revamp and simplify the libpreopen code. (#110) eb7230c Remove more unsupported headers. (#123)
sbc100
force-pushed
the
roll_wasi_libc
branch
from
c60488f to
33bbac7
Compare
|
Seems good to go. I guess the CI doesn't do to much actual testing.. but I've done fair about of wasm-libc-side testing. |
|
Indeed, we don't have a meaningful test suite and we really ought to. |
pchickey
approved these changes
Dec 11, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the following changes:
f645f49 Update signal macros after upgrade to snapshot1 (#144)
8b3266d github actions: pin checkout action to v1 (#145)
410c660 Use constructor functions for optional init routines. (#142)
fe13053 c header generation updated for reorganized witx ast (#139)
cd74e1d Correct the version of #136 on master (#141)
446cb3f Wasi snapshot preview1 (#140)
54102f0 Ignore rights in libpreopen. (#129)
8c9e1c6 Make the
__original_maindefinition weak, fixing -flto. (#138)cf81683 Optimize
fmin,fmax, etc. (#120)deb8eae Don't pre-check capabilities in
openat. (#130)ca9046d Use consistent style for wasi-libc C source files. (#131)
951cc3e Fix unintended recursion in __wasilibc_register_preopened_fd. (#133)
5216983 Avoid a
strdupcall in__wasilibc_populate_libpreopen. (#128)70099d4 Don't link in libpreopen initialization code when it isn't needed. (#127)
ec4549d Temporarily disable the use of
__heap_base. (#132)a214f1c Use __heap_base by dlmalloc (#114)
a94d2d0 Avoid varargs conventions when calling open (#126)
7fcc4f2 Revamp and simplify the libpreopen code. (#110)
eb7230c Remove more unsupported headers. (#123)