fix(machinery): avoid mixing translations with different replacements

The same text and different replacements would use first replacements
only because the text is replaced in the translations dictionary.

Fixes #11179

docs/changes.rst

@@ -24,6 +24,7 @@ Released on June 19th 2024.
 * Fixed behavior of some site-wide :ref:`addons`.
 * Saving strings needing editing to :doc:`/formats/winrc`.
 * :ref:`check-xml-tags` better handle XML entities.
+* Automatic suggestions could mix up replacements between translated strings.
 
 **Compatibility**
 

weblate/machinery/base.py

@@ -527,13 +527,16 @@ def _translate(
             # Postprocess translations
             for text, result in translations.items():
                 for _unit, original_source, replacements in pending[text]:
-                    for item in result:
+                    # Always operate on copy of the dictionaries
+                    partial = [x.copy() for x in result]
+
+                    for item in partial:
                         item["original_source"] = original_source
                     if cache_key:
-                        cache.set(cache_key, result, 30 * 86400)
+                        cache.set(cache_key, partial, 30 * 86400)
                     if replacements or self.force_uncleanup:
-                        self.uncleanup_results(replacements, result)
-                    output[original_source] = result
+                        self.uncleanup_results(replacements, partial)
+                    output[original_source] = partial
         return output
 
     def get_error_message(self, exc: Exception) -> str:

weblate/machinery/tests.py

@@ -373,6 +373,16 @@ def test_placeholders(self) -> None:
             ],
         )
 
+    def test_batch(self):
+        machine_translation = self.get_machine()
+        units = [
+            MockUnit(code="cs", source="Hello, %s!", flags="c-format"),
+            MockUnit(code="cs", source="Hello, %d!", flags="c-format"),
+        ]
+        machine_translation.batch_translate(units)
+        self.assertEqual(units[0].machinery["translation"], ["Nazdar %s!"])
+        self.assertEqual(units[1].machinery["translation"], ["Nazdar %d!"])
+
     def test_key(self) -> None:
         machine_translation = self.get_machine()
         self.assertEqual(