Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong Translation using Xliff with placeholder support #11179

Closed
2 tasks done
19Alex81 opened this issue Mar 12, 2024 · 13 comments · Fixed by #11891
Closed
2 tasks done

Wrong Translation using Xliff with placeholder support #11179

19Alex81 opened this issue Mar 12, 2024 · 13 comments · Fixed by #11891
Assignees
Labels
bug Something is broken.
Milestone

Comments

@19Alex81
Copy link

Describe the issue

I try to automatic translate an Xliff file (articulate rise) using deepl and xliff with placeholder support and some of the translations show a translation from another line. i think this is a chaching issue and i work on the version 5.4.2

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

Translate xliff with automatic placeholder support using deepl

Expected behavior

No response

Screenshots

image

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

Version 5.4.2

Weblate deploy checks

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Mar 12, 2024

Do you see this in Automatic suggestions tab while translating also, or only when performing automatic translation on more strings?

@19Alex81
Copy link
Author

Hi,
Yes seems to be the sam in automatic suggestions
image

@nijel
Copy link
Member

nijel commented Mar 12, 2024

These are added in batch, what I meant is the Automatic suggestions tab in bottom.

@19Alex81
Copy link
Author

There a 3 entrys abd the first and the last one would be correct
image

@nijel
Copy link
Member

nijel commented Mar 12, 2024

Does it add correct suggestions when you delete the bad ones and run Tools / Automatic translation on that language? If so, these might be there from previous versions where such bug did exist.

@19Alex81
Copy link
Author

it does not look like. if i delete the automatic suggestions it appear again after the automatic translation.
is there a way to delet all sugastions from this projekt ?
just to be sure that there are nor relicts from older version

@19Alex81
Copy link
Author

Hello,
I tried deleting the translation memory for this component and only using DeepL for automatic translation, and my problem is getting worse.
image

image

Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Mar 28, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
@nijel nijel reopened this Apr 2, 2024
@nijel nijel added the bug Something is broken. label Apr 2, 2024
@nijel nijel added this to the 5.5 milestone Apr 2, 2024
@nijel
Copy link
Member

nijel commented Apr 20, 2024

Hello, I tried deleting the translation memory for this component and only using DeepL for automatic translation, and my problem is getting worse. image

This seems correct - it does suggest to remove the additional markup.

image

This shows current translations. Please note that the default filter for automatic translation is only to look at strings without a translation, so it won't be applied automatically.

@nijel nijel removed bug Something is broken. wontfix Nobody will work on this. labels Apr 20, 2024
@nijel nijel removed this from the 5.5 milestone Apr 20, 2024
Copy link

github-actions bot commented May 5, 2024

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label May 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
@nijel nijel added bug Something is broken. and removed wontfix Nobody will work on this. labels Jun 18, 2024
@nijel nijel self-assigned this Jun 18, 2024
@nijel nijel added this to the 5.6 milestone Jun 18, 2024
@nijel nijel reopened this Jun 18, 2024
@nijel
Copy link
Member

nijel commented Jun 18, 2024

Thanks to #8673 I probably discovered the issue here.

nijel added a commit to nijel/weblate that referenced this issue Jun 18, 2024
The same text and different replacements would use first replacements
only because the text is replaced in the translations dictionary.

Fixes WeblateOrg#11179
nijel added a commit to nijel/weblate that referenced this issue Jun 18, 2024
The same text and different replacements would use first replacements
only because the text is replaced in the translations dictionary.

Fixes WeblateOrg#11179
@nijel nijel closed this as completed in d53bce1 Jun 18, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

1 similar comment
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants