Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Approved strings are not editable after disabling reviews #12075

Closed
2 tasks done
nijel opened this issue Jul 17, 2024 · 2 comments · Fixed by #12076
Closed
2 tasks done

Approved strings are not editable after disabling reviews #12075

nijel opened this issue Jul 17, 2024 · 2 comments · Fixed by #12076
Assignees
@nijel
Labels
bug Something is broken.
Milestone
5.7

Comments

@nijel
Copy link
Member

nijel commented Jul 17, 2024

Describe the issue

Approved strings are not editable after disabling reviews

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Enable reviews
  2. Mark string as approved
  3. Disable reviews
  4. See the string is not editable (Only reviewers can change approved strings)

Expected behavior

String should be editable as reviews are not disabled

Screenshots

Bildschirmfoto_2024-07-16_12-57-23

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

#12069
@nijel nijel added the bug Something is broken. label Jul 17, 2024
@nijel nijel added this to the 5.7 milestone Jul 17, 2024
@nijel nijel self-assigned this Jul 17, 2024
nijel added a commit to nijel/weblate that referenced this issue Jul 17, 2024
@nijel
fix(permissions): do not deny editing approved strings without reviews
0746215 
This might happen after disabling reviews and having approved strings.
On the other side we don't want to wipe out approved states immediatelly
in case user is doing some more changes (for example changing
per-language workflows).

Fixes WeblateOrg#12075
@nijel nijel mentioned this issue Jul 17, 2024
Merged
5 tasks
@nijel nijel closed this as completed in 80522bc Jul 17, 2024
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

1 similar comment
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nijel nijel

Labels
bug Something is broken.
Projects
None yet
Milestone
5.7
Development

Successfully merging a pull request may close this issue.

fix(permissions): do not deny editing approved strings without reviews nijel/weblate
1 participant
@nijel