Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(permissions): do not deny editing approved strings without reviews #12076

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Jul 17, 2024

Proposed changes

This might happen after disabling reviews and having approved strings. On the other side we don't want to wipe out approved states immediatelly in case user is doing some more changes (for example changing per-language workflows).

Fixes #12075

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

This might happen after disabling reviews and having approved strings.
On the other side we don't want to wipe out approved states immediatelly
in case user is doing some more changes (for example changing
per-language workflows).

Fixes WeblateOrg#12075
@nijel nijel added this to the 5.7 milestone Jul 17, 2024
@nijel nijel self-assigned this Jul 17, 2024
@nijel nijel enabled auto-merge (rebase) July 17, 2024 07:01
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (6aee586) to head (0746215).
Report is 4998 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12076      +/-   ##
==========================================
- Coverage   90.82%   90.58%   -0.24%     
==========================================
  Files         554      582      +28     
  Lines       57306    59279    +1973     
  Branches     9122     9474     +352     
==========================================
+ Hits        52046    53697    +1651     
- Misses       3640     3873     +233     
- Partials     1620     1709      +89     
Files with missing lines Coverage Δ
weblate/auth/permissions.py 88.88% <100.00%> (-0.05%) ⬇️

... and 358 files with indirect coverage changes

@nijel nijel merged commit 80522bc into WeblateOrg:main Jul 17, 2024
32 checks passed
@nijel nijel deleted the auth-review branch July 17, 2024 09:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Approved strings are not editable after disabling reviews
1 participant