Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(permissions): do not deny editing approved strings without reviews #12076

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix(permissions): do not deny editing approved strings without reviews #12076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions weblate/auth/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,12 @@ def check_edit_approved(user: User, permission: str, obj: Model):
if not unit.source_unit.translated:
return Denied(gettext("The source string needs review."))
return Denied(gettext("The string is read only."))
if unit.approved and not check_unit_review(
user, "unit.review", obj, skip_enabled=True
# Ignore approved state if review is not disabled. This might
# happen after disabling them.
if (
unit.approved
and obj.enable_review
and not check_unit_review(user, "unit.review", obj, skip_enabled=True)
):
return Denied(
gettext(
Expand Down
Loading