Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

2025 base code #7

Merged
merged 4 commits into from
Jan 8, 2025
Merged

2025 base code #7

merged 4 commits into from
Jan 8, 2025

Conversation

sconstantine08
Copy link
Contributor

No description provided.

@sconstantine08
Copy link
Contributor Author

resolves issue #1

This was linked to issues Jan 6, 2025
@jasonsoohoo
Copy link
Member

This issue is supposed to solely initializing the project. I would appreciate following instructions in the future. I will pass this MR to close issues #1 and #2 so we can get the ball rolling this time.

@jasonsoohoo
Copy link
Member

Remove the advantagekit library for this MR.
Provide justification for using the REV library when its out of scope for these issues (if you include something outside of the spec, provide details or description of why you're doing so)
Remove all example files. We will not be using them on the robot, why are they there?

@Ferris-Bueller7
Copy link
Collaborator

I agree with Jason, splitting it up makes it easier to manage in the long run. Also adding external libraries as needed instead of early is always cleaner so in future PRs lets make sure that we are only adding external libraries that is relevant to code being pushed.

@sconstantine08 sconstantine08 merged commit 305d871 into production Jan 8, 2025
@sconstantine08 sconstantine08 deleted the 2025-Initial branch January 8, 2025 01:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CTRE Lib and Pathplanner Initialize 2025 Command Based Robot
3 participants