feat: Add workflow to check config description #1894
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1894 +/- ##
===========================================
+ Coverage 72.71% 73.18% +0.46%
===========================================
Files 333 337 +4
Lines 13525 13822 +297
Branches 6881 7008 +127
===========================================
+ Hits 9835 10115 +280
+ Misses 1785 1780 -5
- Partials 1905 1927 +22 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Logic looks good to me.
I am not against adding generated file to repo. I think it is better to give developer enough instruction how to update this generated file. Please ignore my comment if there is instruction somewhere 😄
For example: we can
1 Give instruction when check fails in CI job
2 Create a CMake target which depends on ConfigDescription.cpp file, it will update the markdown file during building when ConfigDescription.cpp is amended.
3 At the beginning of the config-description.md, we add This is generated file, don't amend it manually , please run balabala
Improving array parsing in config: - Allow null values in arrays for optional fields - Allow empty array even for required field - Allow to not put an empty array in config even if array contains required fields
Fixes XRPLF#1919. Please review and commit clang-tidy fixes. Co-authored-by: godexsoft <385326+godexsoft@users.noreply.github.com>
Fixes XRPLF#1924. Please review and commit clang-tidy fixes. Co-authored-by: godexsoft <385326+godexsoft@users.noreply.github.com>
There was a data race inside `CoroutineGroup` because internal timer was used from multiple threads in the methods `asyncWait()` and `onCoroutineComplete()`. Changing `registerForeign()` to spawn to the same `yield_context` fixes the problem because now the timer is accessed only from the same coroutine which has an internal strand. During debugging I also added websocket support for `request_gun` tool.
fixes #1880