allow redirects on Bridgy, Bridgy Fed, and appspot.com #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strpos(string, sub)` returns `false` if `sub` is not present in `string`. In this case, we want to check if `sub` is not a *prefix* of `string`. Hence, we just need to test if the returned position is simply different from 0.
The test is checking for notes, but 'Bridge Fed' is, in fact, an article according to the post discovery algorithm. Also, I'm adding as note that the main difference between a note and an article is that the latter has a title, while the first doesn't.
fix: check prefix correctly
Updates to support php 8 anc CI
Fix preg_replace deprecations
* Added isImgAlt static method to Formats\Mf2 * Used it in collectArrayURLValues and getPlaintext to handle cases where img+alt structures are encountered Additionally disabled reporting of deprecation warnings while testing for a cleaner output. All tests are passing.
* Default options are applied to calls to parse(), rels(), feeds() and process() * Default options are overridden by options passed to the respective function call on a property-by-property basis * Documented in README with example * Added basic test (only for parse() behaviour) * Also fixed a bug causing an error processing h-cards with no URL property
… h-cards with no URL
Allow installation alongside php-mf2 v0.5
Used default options for fetching as well as parsing
fixes aaronpk#118. as far as we can tell, this is probably the root cause of many of these bugs filed against webmention.io over the last couple years, https://github.com/aaronpk/webmention.io/issues , eg #188, #187, #175, #173, etc. @aaronpk [said](https://chat.indieweb.org/dev/2023-08-07#t1691382116891200): > That was apparently added 8 years ago > i vaguely remember some old issue with appspot URLs that I had to work around that appspot URL issue was probably that it required SNI for SSL, which was less supported then, and much more widely supported now, so I'm pretty sure this change is ok. cc @osa_k
snarfed
force-pushed
the
allow-bridgy-redirects
branch
from
fb4487e to
c247379
Compare
|
Dunno what git/GitHub did here but it's not right. Closing in favor of #120. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #118. as far as we can tell, this is probably the root cause of many of these bugs filed against webmention.io over the last couple years, https://github.com/aaronpk/webmention.io/issues , eg #188, #187, #175, #173, etc.
@aaronpk said:
that appspot URL issue was probably that it required SNI for SSL, which was less supported then, and much more widely supported now, so I'm pretty sure this change is ok.
cc @osak