allow redirects on Bridgy, Bridgy Fed, and appspot.com #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes aaronpk#118. as far as we can tell, this is probably the root cause of many of these bugs filed against webmention.io over the last couple years, https://github.com/aaronpk/webmention.io/issues , eg #188, #187, #175, #173, etc. @aaronpk [said](https://chat.indieweb.org/dev/2023-08-07#t1691382116891200): > That was apparently added 8 years ago > i vaguely remember some old issue with appspot URLs that I had to work around that appspot URL issue was probably that it required SNI for SSL, which was less supported then, and much more widely supported now, so I'm pretty sure this change is ok. cc @osa_k
This was referenced Aug 11, 2023
This was referenced Aug 17, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #118. as far as we can tell, this is probably the root cause of a number of bugs filed against webmention.io over the last couple years, eg aaronpk/webmention.io#188, aaronpk/webmention.io#187, aaronpk/webmention.io#175, aaronpk/webmention.io#173, etc.
@aaronpk said:
that appspot URL issue was probably that it required SNI for SSL, which was less supported then, and much more widely supported now, so I'm pretty sure this change is ok.
cc @osak