[libraries] Get examiner sites by UserID (#8994)

Fix bug where if a user has the same full name as another user, the examiner sites from the other user will show up in the edit user page.
aces · Dec 12, 2023 · 5b7ddb2 · 5b7ddb2
1 parent 6b67272
commit 5b7ddb2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/php/libraries/User.class.inc b/php/libraries/User.class.inc
@@ -122,12 +122,12 @@ class User extends UserPermissions implements
                     epr.pending_approval
                   FROM examiners e
                   JOIN examiners_psc_rel epr ON (e.examinerID=epr.examinerID)
-                  WHERE e.full_name=:fn
+                  WHERE e.userID=:uid
                     AND (epr.active='Y'
                           OR (epr.active='N' AND epr.pending_approval='Y')
                         )",
             [
-                "fn" => $row['Real_name'],
+                "uid" => $row['ID'],
             ]
         );
 

diff --git a/test/unittests/UserTest.php b/test/unittests/UserTest.php
@@ -105,6 +105,7 @@ class UserTest extends TestCase
      * @var array
      */
     private $_examinerInfo = [0 => ['full_name' => 'John Doe',
+        'userID'      => '1',
         'examinerID'  => 1,
         'radiologist' => 1
     ]