Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[libraries] Get examiner sites by UserID #8994

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

CamilleBeau
Copy link
Contributor

Brief summary of changes

We found this bug on CCNA where if a user has the same full name as another user, the examiner sites from the other user will show up in the edit user page.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Outside of this PR, Create 2 users with the same name
  2. Set one user as examiner at multiple sites
  3. Go to the other user, and see that the same sites show up as examiner
  4. Try to remove the examiner sites and notice that you cannot
  5. Checkout this PR and refresh the second user (without the examiner sites)
  6. Now you should not see examiner sites where they are not meant to be

@driusan
Copy link
Collaborator

driusan commented Dec 5, 2023

@CamilleBeau The tests on this are failing

@CamilleBeau
Copy link
Contributor Author

@CamilleBeau The tests on this are failing

Fixed! Thanks

Copy link
Contributor

@shonibare shonibare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 5b7ddb2 into aces:24.1-release Dec 12, 2023
9 checks passed
@ridz1208 ridz1208 added this to the 24.1.6 milestone Apr 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants