Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[tools/install.sh] not working like before #5244

Closed
maltheism opened this issue Sep 24, 2019 · 4 comments
Closed

[tools/install.sh] not working like before #5244

maltheism opened this issue Sep 24, 2019 · 4 comments
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@maltheism
Copy link
Member

maltheism commented Sep 24, 2019

I've been using the tools/install.sh to generate the config.xml inside the project directory.

Changes have been made to install.sh and now the script will stop before making the config.xml file unlike before.

Basically if a "user_uploads" directory already exists and this can be in the document_repository or the data_release module. I would prefer the script to just skip the create directory commands if the directories already exists. Otherwise I have to manually delete the directories before I can run the script again and unlike before.

Also the script is reporting:

mkdir: cannot create directory ‘../modules/document_repository/user_uploads’: File exists
Note: user_uploads is not a file.

@maltheism maltheism added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Sep 24, 2019
@johnsaigle
Copy link
Contributor

Related-ish: #5062

@johnsaigle
Copy link
Contributor

Opened #5245 to address this.

I'm confused about where your config file went though. Why do you need to regenerate it?

@maltheism
Copy link
Member Author

@johnsaigle I usually delete project and then run the install.sh before the install

@christinerogers
Copy link
Contributor

Why do you need to regenerate it though? e.g. Are you working on a cloned VM?

driusan pushed a commit that referenced this issue Sep 26, 2019
Adds -p flag to mkdir so that the install script won't fail when user_uploads/ already exists (for whatever reason) in doc_repo or data_release.

Fixes #5244.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

No branches or pull requests

3 participants