Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Install] Add -p to mkdir so install doesn't fail #5245

Merged
merged 1 commit into from
Sep 26, 2019
Merged

[Install] Add -p to mkdir so install doesn't fail #5245

merged 1 commit into from
Sep 26, 2019

Conversation

johnsaigle
Copy link
Contributor

@johnsaigle johnsaigle commented Sep 24, 2019 •
edited
Loading

Brief summary of changes

Adds -p flag to mkdir so that the install script won't fail when user_uploads/ already exists (for whatever reason) in doc_repo or data_release.

Fixes #5244.

@johnsaigle johnsaigle added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Sep 24, 2019
@johnsaigle johnsaigle mentioned this pull request Sep 24, 2019
Closed
@johnsaigle johnsaigle added the Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS label Sep 24, 2019
@johnsaigle
Copy link
Contributor Author

@maltheism Please let me know whether this resolves your issue (#5244).

christinerogers
christinerogers approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though we should also add a check/warning at top if these do exist.

@kongtiaowang kongtiaowang added the Passed Manual Tests PR has undergone proper testing by at least one peer label Sep 25, 2019
@driusan driusan removed the Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS label Sep 26, 2019
@driusan driusan merged commit 6160181 into aces:minor Sep 26, 2019
@ridz1208 ridz1208 added this to the 21.1.0 milestone Oct 1, 2019
@johnsaigle johnsaigle mentioned this pull request Oct 7, 2019
Closed
@ridz1208 ridz1208 modified the milestones: 21.1.0, 22.0.0 Nov 1, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@christinerogers christinerogers christinerogers approved these changes

@maltheism maltheism maltheism approved these changes

Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
22.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@johnsaigle @christinerogers @maltheism @driusan @kongtiaowang @ridz1208