Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[instrument_builder] Numeric Min/Max fields auto-populated with "0" #6568

Closed
zaliqarosli opened this issue May 21, 2020 · 0 comments · Fixed by #6810
Closed

[instrument_builder] Numeric Min/Max fields auto-populated with "0" #6568

zaliqarosli opened this issue May 21, 2020 · 0 comments · Fixed by #6810
Assignees
@laemtl
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@zaliqarosli
Copy link
Contributor

zaliqarosli commented May 21, 2020 •
edited
Loading

Describe the bug
While a numeric element can be added without 'Min' and 'Max' values, the default value "0" for both 'Min' and 'Max' fields return 'Max value must be larger than min value' error on clicking 'Add Row'.

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to 'Instrument Builder' module and click on the 'Build' tab
  2. Click on the 'Select One' dropdown and select 'Numeric' under 'Data entry'
  3. Fill out 'Question Name' and 'Question Text' fields, leaving 'Min' and 'Max' fields (already populated with "0") untouched. Click 'Add Row'. This will trigger the error 'Max value must be larger than min value'.
  4. Remove the zeros from the 'Min' and 'Max' fields, leaving them empty. Click 'Add Row'.
    The element should save in the 'Question Display (Front End)' table above.

What did you expect to happen?
The 'Min' and 'Max' fields should be empty as the default
@zaliqarosli zaliqarosli added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label May 21, 2020
@laemtl laemtl self-assigned this Jul 6, 2020
@laemtl laemtl mentioned this issue Jul 6, 2020
Merged
driusan pushed a commit that referenced this issue Jul 15, 2020
@laemtl
[instrument builder] Min/max null default value (#6810)
c102d48 
The default value "0" for both 'Min' and 'Max' fields return 'Max value must be larger than min value' error on clicking 'Add Row'.
The 'Min' and 'Max' fields are now empty as the default.

    Resolves #6568
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 29, 2021
@laemtl @AlexandraLivadas
[instrument builder] Min/max null default value (aces#6810)
32e7772 
The default value "0" for both 'Min' and 'Max' fields return 'Max value must be larger than min value' error on clicking 'Add Row'.
The 'Min' and 'Max' fields are now empty as the default.

    Resolves aces#6568
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@laemtl laemtl

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[instrument builder] Min/max null default value laemtl/Loris
2 participants
@zaliqarosli @laemtl