-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[instrument builder] Min/max null default value #6810
[instrument builder] Min/max null default value #6810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately by default, the error message is popping up even if you don't touch the min and max fields. you'll need to modify the less/greater than check to consider the case when the values are null.
for some reason, if you fill in the fields with a number, and then delete them, the error doesn't pop up because the last number of the two that you delete becomes a 'NaN' type which apparently passes the less/greater than check:
Thanks @zaliqarosli, I will fix that! |
a6794ff
to
700ef20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am able to add a numeric value with min 0 and max 0 without the error popping up
700ef20
to
8febd71
Compare
The default value "0" for both 'Min' and 'Max' fields return 'Max value must be larger than min value' error on clicking 'Add Row'. The 'Min' and 'Max' fields are now empty as the default. Resolves aces#6568
The default value "0" for both 'Min' and 'Max' fields return 'Max value must be larger than min value' error on clicking 'Add Row'.
The 'Min' and 'Max' fields are now empty as the default.