Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[instrument builder] Min/max null default value #6810

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jul 6, 2020

The default value "0" for both 'Min' and 'Max' fields return 'Max value must be larger than min value' error on clicking 'Add Row'.
The 'Min' and 'Max' fields are now empty as the default.

@laemtl laemtl added the Proposal PR or Issue suggesting an improvement that can be accepted, rejected or altered label Jul 6, 2020
Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately by default, the error message is popping up even if you don't touch the min and max fields. you'll need to modify the less/greater than check to consider the case when the values are null.

Screen Shot 2020-07-07 at 7 08 47 PM

for some reason, if you fill in the fields with a number, and then delete them, the error doesn't pop up because the last number of the two that you delete becomes a 'NaN' type which apparently passes the less/greater than check:

Screen Shot 2020-07-07 at 7 13 05 PM

@laemtl
Copy link
Contributor Author

laemtl commented Jul 7, 2020

Thanks @zaliqarosli, I will fix that!

@laemtl laemtl force-pushed the 2020-07-06-instrument-builder-min-max branch 2 times, most recently from a6794ff to 700ef20 Compare July 8, 2020 20:27
@laemtl laemtl requested a review from zaliqarosli July 8, 2020 20:28
Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am able to add a numeric value with min 0 and max 0 without the error popping up

@laemtl laemtl force-pushed the 2020-07-06-instrument-builder-min-max branch from 700ef20 to 8febd71 Compare July 14, 2020 04:55
@laemtl laemtl requested a review from zaliqarosli July 14, 2020 13:44
@zaliqarosli zaliqarosli added the Passed Manual Tests PR has undergone proper testing by at least one peer label Jul 14, 2020
@driusan driusan merged commit c102d48 into aces:master Jul 15, 2020
@ridz1208 ridz1208 added this to the 24.0.0 milestone Jul 15, 2020
@laemtl laemtl deleted the 2020-07-06-instrument-builder-min-max branch July 21, 2020 19:11
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
The default value "0" for both 'Min' and 'Max' fields return 'Max value must be larger than min value' error on clicking 'Add Row'.
The 'Min' and 'Max' fields are now empty as the default.

    Resolves aces#6568
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer Proposal PR or Issue suggesting an improvement that can be accepted, rejected or altered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[instrument_builder] Numeric Min/Max fields auto-populated with "0"
4 participants