Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Core] Download csv duplicate/non-matching rows on filtered content #7229

Closed
laemtl opened this issue Dec 16, 2020 · 1 comment · Fixed by #7242
Closed

[Core] Download csv duplicate/non-matching rows on filtered content #7229

laemtl opened this issue Dec 16, 2020 · 1 comment · Fixed by #7242
Assignees
@laemtl
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@laemtl
Copy link
Contributor

laemtl commented Dec 16, 2020 •
edited
Loading

To Reproduce
Steps to reproduce the behavior:

  1. Go to the publications page
  2. Filter using more than one criteria (ex: title and keyword value)
  3. Download the CSV. The rows matching all criteria appear twice, the ones matching only some are not removed.
@laemtl laemtl added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 23.0.0-testing labels Dec 16, 2020
@laemtl laemtl self-assigned this Dec 16, 2020
@laemtl laemtl mentioned this issue Dec 17, 2020
Merged
@laemtl laemtl changed the title [Publication] Download csv duplicate rows [Core] Download csv duplicate rows Dec 17, 2020
@laemtl laemtl changed the title [Core] Download csv duplicate rows [Core] Download csv duplicate/non-matching rows Dec 17, 2020
@laemtl laemtl changed the title [Core] Download csv duplicate/non-matching rows [Core] Download csv duplicate/non-matching rows on filtered content Dec 17, 2020
driusan pushed a commit that referenced this issue Dec 21, 2020
@laemtl
[Core] Download CSV duplicates fix (#7242)
11a56fe 
This addresses 2 issues related to downloading of CSVs:

1. When a row matches 2 filtering criteria, this row is included twice in the CSV
2. Rows partially matching the filtering criteria are included in the CSV

    Resolves #7229
@driusan
Copy link
Collaborator

driusan commented Dec 22, 2020

Merged

@driusan driusan closed this as completed Dec 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@laemtl laemtl

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Download CSV issues laemtl/Loris
2 participants
@driusan @laemtl