Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Core] Download CSV issues #7242

Merged
merged 1 commit into from
Dec 21, 2020
Merged

[Core] Download CSV issues #7242

merged 1 commit into from
Dec 21, 2020

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Dec 17, 2020 •
edited
Loading

This PR solves 2 issues:

  • when a row matches 2 filtering criteria, this row is included twice in the csv
  • the rows matching the filtering criteria partially are included in the csv

The bug was found on the publication module and probably affects all modules using the StaticDataTable.

To test

Filter a data table with 2 criteria:

  • check that the rows matching all criteria are not included twice in the csv
  • check that the rows that match some but not all criteria are not included in the csv

@laemtl laemtl force-pushed the 2020-12-17-table-csv-dups-fix branch from 6aba93b to ff0a15c Compare December 17, 2020 15:34
@laemtl laemtl closed this Dec 17, 2020
@laemtl laemtl force-pushed the 2020-12-17-table-csv-dups-fix branch from ff0a15c to c1383f3 Compare December 17, 2020 15:40
@laemtl laemtl reopened this Dec 17, 2020
@laemtl laemtl changed the base branch from main to 23.0-release December 17, 2020 15:43
@laemtl laemtl force-pushed the 2020-12-17-table-csv-dups-fix branch from 874caec to cd7ec82 Compare December 17, 2020 17:41
@laemtl laemtl changed the title [Core] Download CSV duplicates fix [Core] Download CSV issues Dec 17, 2020
maltheism
maltheism approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@maltheism maltheism left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual testing

@maltheism maltheism added the Passed Manual Tests PR has undergone proper testing by at least one peer label Dec 17, 2020
@driusan driusan merged commit 11a56fe into aces:23.0-release Dec 21, 2020
@ridz1208 ridz1208 added this to the 23.0.3 milestone Feb 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maltheism maltheism maltheism approved these changes

Assignees
No one assigned
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
23.0.3
Development

Successfully merging this pull request may close these issues.

[Core] Download csv duplicate/non-matching rows on filtered content
4 participants
@laemtl @maltheism @driusan @ridz1208