Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

StaticDataTable Hide defaultColumn does not work #7470

Closed
driusan opened this issue Jun 9, 2021 · 1 comment · Fixed by #7473
Closed

StaticDataTable Hide defaultColumn does not work #7470

driusan opened this issue Jun 9, 2021 · 1 comment · Fixed by #7473
Assignees
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@driusan
Copy link
Collaborator

driusan commented Jun 9, 2021

*When a StaticDataTable has the Hide prop set to include {defaultColumn: true} the header is hidden, but the numbered column in the table itself is still displayed, causing all the headers and rows to be misaligned.

@driusan driusan added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Jun 9, 2021
@ridz1208 ridz1208 assigned driusan and laemtl and unassigned driusan Jan 31, 2023
@ridz1208
Copy link
Collaborator

@laemtl to assign it to Dave

driusan added a commit that referenced this issue Feb 20, 2023
This converts the MRI Violations module to React. While doing so, is simplifies the subpages. They are no longer menu filters, but modal popup windows that display all details of errors for a scan when the link is clicked. All violations for the SeriesUID are shown to provide context. The maintenance should also be simplified by having converted most types of queries to DataProvisioners, which makes it easier to see the query and copy/paste into SQL. This should also result in more consistency with how CenterID/ProjectID matches are handled with the rest of LORIS.

Fixes #7470
Fixes #5714 (the pages no longer exist)
Fixes #6576 (there is only one page with filters now)
Fixes #6839 (the pages no longer exist, so don't have tabs..)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants