Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[imaging_uploader] Visit Label populated from the entire end of the file name #8803

Closed
zaliqarosli opened this issue Jun 20, 2023 · 2 comments · Fixed by #8881
Closed

[imaging_uploader] Visit Label populated from the entire end of the file name #8803

zaliqarosli opened this issue Jun 20, 2023 · 2 comments · Fixed by #8881
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 25.0.0 - Bugs Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) UI PR or issue introducing/requiring improvements to the LORIS User Interface

Comments

@zaliqarosli
Copy link
Contributor

zaliqarosli commented Jun 20, 2023

Visit Label should only be populated by the third parameter in the file name, not the rest of the file name after CandID (as is what's happening)

The "Notes" below the uploader states "For files that are not Phantom Scans, file name must begin with [PSCID][CandID][Visit Label]", so anything after VisitLabel should be accepted, even if not a required parameter

i.e. in the screenshot (1), Visit Label is auto-populated as 'MRI02_MNI_20230428_105929723' when should just be 'MRI02'. The Visit Label incorrectly populating results in an error (2).

(1)Screenshot 2023-06-20 at 6 37 33 PM

(2)Screenshot 2023-06-20 at 6 41 09 PM

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What did you expect to happen?
A clear and concise description of what you expected to happen.

Browser Environment (please complete the following information):

  • OS: [e.g. Plan9, HURD, Oberon, etc]
  • Browser [e.g. chrome, firefox] (note that only these two browsers are supported)
  • Version [e.g. 22]

Server Environment (if known):
Note: We only support the most recent release of LORIS.

  • LORIS Version: [e.g. 22.0.0]
  • Linux distribution and Version: [e.g. Ubuntu 16.04, CentOS 7]
  • MySQL/MariaDB Version: [e.g. MySQL 5.7, MariaDB 10.3]

Additional context
Add any other context about the problem here.

@zaliqarosli zaliqarosli added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 25.0.0 - Bugs UI PR or issue introducing/requiring improvements to the LORIS User Interface labels Jun 20, 2023
@zaliqarosli zaliqarosli mentioned this issue Jun 20, 2023
15 tasks
@zaliqarosli zaliqarosli added the 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 label Aug 17, 2023
@ridz1208
Copy link
Collaborator

@zaliqarosli issues started here #5306

@zaliqarosli zaliqarosli linked a pull request Sep 7, 2023 that will close this issue
1 task
driusan pushed a commit that referenced this issue Sep 12, 2023
Properly handle parsing/auto-populating of visit label when there is a suffix after the visit label in the file name.

Fixes #8803
@zaliqarosli
Copy link
Contributor Author

PR merged

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 25.0.0 - Bugs Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) UI PR or issue introducing/requiring improvements to the LORIS User Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants