[imaging_uploader] Fix auto-populating VisitLabel #8881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaliqarosli
added
the
Bug
zaliqarosli
commented
Sep 7, 2023
zaliqarosli
commented
Sep 7, 2023
zaliqarosli
commented
Sep 7, 2023
zaliqarosli
commented
Sep 7, 2023
ridz1208
reviewed
Sep 8, 2023
Comment on lines
+69
to
+84
| // visitLabel can contain underscores, filename can have suffix appended to PSCID_CandID_VisitLabel | ||
| // join the remaining elements of patientName and pattern match | ||
| // against each visit label. Use as visitLabel the best (longest) match | ||
| ids.splice(0, 2); | ||
| formData.visitLabel = ids.join('_'); | ||
| const suffix = ids.join('_'); | ||
| const visitLabels = Object.keys(form.visitLabel.options); | ||
| let bestMatch = ''; | ||
| visitLabels.map((visitLabel) => { | ||
| if (suffix.match(visitLabel) !== null) { | ||
| // consider the first match only | ||
| if (suffix.match(visitLabel)[0].length > bestMatch.length) { | ||
| bestMatch = suffix.match(visitLabel)[0]; | ||
| } | ||
| } | ||
| }); | ||
| formData.visitLabel = bestMatch; |
There was a problem hiding this comment.
I feel like I heard somewhere that phantom scans names don't get validated? but im not sure and this doesnt hurt it only helps
There was a problem hiding this comment.
this case isn't for phantom scans, its in the else if statement. the difference between this block of code and the block below is the auto-populating happening if you're filling out the IsPhantom first or the mriFile first, i think
ridz1208
approved these changes
Sep 8, 2023
ridz1208
added
the
Priority: Projects
|
@driusan blocking issue for CBIGR |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Fixes #8803
Testing instructions (if applicable)
Link(s) to related issue(s)