[Integration] changeUserProject helper function, candidate_profile tests #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraLivadas
added
Testing
christinerogers
requested changes
Aug 14, 2020
| $this->setupPermissions(["data_entry"]); | ||
| $this->safeGet($this->url . "/900000/"); | ||
| $bodyText | ||
| = $this->webDriver->findElement(WebDriverBy::cssSelector("body")) |
There was a problem hiding this comment.
Suggested change
| = $this->webDriver->findElement(WebDriverBy::cssSelector("body")) | |
| = $this->safeFindElement(WebDriverBy::cssSelector("body")) |
| $this->setupPermissions(["data_entry"]); | ||
| $this->safeGet($this->url . "/900000/"); | ||
| $bodyText | ||
| = $this->webDriver->findElement(WebDriverBy::cssSelector("body")) |
There was a problem hiding this comment.
Suggested change
| = $this->webDriver->findElement(WebDriverBy::cssSelector("body")) | |
| = $this->safeFindElement(WebDriverBy::cssSelector("body")) |
| { | ||
| $this->safeGet($this->url . "/900000/"); | ||
| $bodyText | ||
| = $this->webDriver->findElement(WebDriverBy::cssSelector("body")) |
There was a problem hiding this comment.
Suggested change
| = $this->webDriver->findElement(WebDriverBy::cssSelector("body")) | |
| = $this->safeFindElement(WebDriverBy::cssSelector("body")) |
| $bodyText | ||
| = $this->webDriver->findElement(WebDriverBy::cssSelector("body")) | ||
| ->getText(); | ||
| $this->assertContains("Candidate Profile", $bodyText); |
There was a problem hiding this comment.
Suggested change
| $this->assertContains("Candidate Profile", $bodyText); | |
| $this->assertContains("Candidate Profile 900000", $bodyText); |
There was a problem hiding this comment.
to make sure the string it not on the dropdown menu.
AlexandraLivadas
changed the title
christinerogers
approved these changes
Aug 18, 2020
|
I tested it with no problem. LGTM! |
AlexandraLivadas
added
the
Passed Manual Tests
christinerogers
removed
the
Proposal
spell00
approved these changes
Aug 24, 2020
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Sep 3, 2020
…sts (aces#6912) Add 2 helper functions, changeProject and resetProject, to the LorisIntegrationTest.class.inc class. These will allow us to test project permissions on modules. Also added initial integration tests for the candidate_profile module, including a project permission test. Resolves aces#6911
AlexandraLivadas
added a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
…sts (aces#6912) Add 2 helper functions, changeProject and resetProject, to the LorisIntegrationTest.class.inc class. These will allow us to test project permissions on modules. Also added initial integration tests for the candidate_profile module, including a project permission test. Resolves aces#6911
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 2 helper functions,
changeProjectandresetProject, to the LorisIntegrationTest.class.inc class. These will allow us to test project permissions on modules.I also added initial integration tests for the
candidate_profilemodule, including a project permission test.Testing instructions
npm run tests:integration -- --filter CandidateProfileIntegrationTestLink to related issue