Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[EEG Browser] Integration testing for EEG Browser module #6922

Merged
merged 6 commits into from
Sep 1, 2020

Conversation

AlexandraLivadas
Copy link
Contributor

Adding integration tests for the electrophysiology_browser module

Testing instructions (if applicable)

  1. Check out Travis or run the command npm run tests:integration -- --filter EEGBrowserIntegrationTest

@AlexandraLivadas AlexandraLivadas added Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix Testing PR contains test plan or automated test code (or config files for Travis) labels Aug 18, 2020
@@ -348,6 +348,38 @@ abstract class LorisIntegrationTest extends TestCase
$this->DB->run('SET foreign_key_checks =1');
}

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed once #6912 is merged. These are helper functions to test project permissions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed

@AlexandraLivadas AlexandraLivadas removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Aug 24, 2020
@AlexandraLivadas AlexandraLivadas added the Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch label Aug 25, 2020
@AlexandraLivadas AlexandraLivadas removed the Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch label Aug 25, 2020
@AlexandraLivadas
Copy link
Contributor Author

@kongtiaowang This is ready for review, do you mind taking a look in the next few days?

Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit c829b5a into aces:main Sep 1, 2020
laemtl pushed a commit to laemtl/Loris that referenced this pull request Sep 3, 2020
Adding integration tests for the electrophysiology_browser module.
zaliqarosli pushed a commit to zaliqarosli/Loris that referenced this pull request Sep 3, 2020
Adding integration tests for the electrophysiology_browser module.
@ridz1208 ridz1208 added this to the 24.0.0 milestone Nov 27, 2020
AlexandraLivadas added a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
Adding integration tests for the electrophysiology_browser module.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants