[new_profile] Use API for candidate creation and swal for success

[driusan]

This updates the candidate creation on the new profile page to
use the LORIS API instead of duplicating the logic in PHP. The form
already collects the exact data that a POST request to the API
requires, but submits it to a different endpoint in a form encoding
instead of a json encoding.

At the same time, the logic for the response is simplified by using
a swal instead of a (very empty looking) new page. swals are already
used for errors in the module, just not success. This change simplifies
both the code and the UX.

[driusan]

Blocked by the release. Set it to "Draft" so that it doesn't accidentally get merged beforehand.

[xlecours]

This will throw a parse error when an html page is returned by the backend (session expired, forbidden, 500, etc)
In those cases, It might be relevant to fire the swal.

[driusan]

Which part? the resp.json() or changing message to message.error? And why does forbidden return html? (It didn't seem to when I was testing..)

[xlecours]

I would say thta it is because the class is extending \NDB_Form and not Endpoint. It's wraped by a UserPage Decorator middleware that only prints html. Regardless of specifics, there are cases where html will be returned and resp.json() will not be happy. ONe way of handling that is to put the

this.setState({submitDisabled: false});
swal.fire('Error!', message.error, 'error');

parts in the catch; and throw resp.json().message in the else.

[xlecours]

Nice!
Additionally, in modules/new_profile/php/new_profile.class.inc, private $_error; can be removed.

[driusan]

looks like that's also true of _pscid and _candID and all the namespaces (which phan was complaining about).. should be fixed in the last commit.

[driusan]

@xlecours now that the release is out I removed the blocked tag and rebased this, can you re-review it?

[xlecours]

I see a mixte of 2 and 4 spaces indentation in the js files.
The resp.json() potential parse error is still not handled. A swal showing failure would be better than a console.error I think.
It's failing CI
There was 1 error:

1. NewProfileTestIntegrationTest::testNewProfileCreateCandidate
   Facebook\WebDriver\Exception\NoSuchElementException: Unable to locate element: #lorisworkspace > fieldset > div > div > p:nth-child(1)
   Other than that it's great :)

[driusan]

@xlecours I've fixed the indentation, added a catch to the code paths that don't have a catch for the resp.json(), fixed an error in the API that was causing it to return non-JSON and, if the gods are good, fixed the failing test by checking the swal title instead of an element in the body. (Still needs to run on GitHub to be sure that it's working..)

[xlecours]

This, is good.

[xlecours]

@driusan I haven't tested it because I am in the middle of other things.

[xlecours]

@driusan Tested now. it's working all right.