Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[new_profile] Use API for candidate creation and swal for success #7755

Merged
merged 6 commits into from
Oct 27, 2022
Merged

[new_profile] Use API for candidate creation and swal for success #7755

merged 6 commits into from
Oct 27, 2022

Commits on Oct 25, 2022

  1. [new_profile] Use API for candidate creation and swal for success 

    This updates the candidate creation on the new profile page to
se the LORIS API instead of duplicating the logic in PHP. The form
already collects the exact data that a POST request to the API
requires, but submits it to a different endpoint in a form encoding
instead of a json encoding.

At the same time, the logic for the response is simplified by using
a swal instead of a (very empty looking) new page. swals are already
used for errors in the module, just not success. This change simplifies
both the code and the UX.
    @driusan
    driusan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    146751b View commit details
    Browse the repository at this point in the history

  2. phan and unused variables

    @driusan
    driusan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    de1a0dd View commit details
    Browse the repository at this point in the history

  3. Check swal title instead of body text for string

    @driusan
    driusan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    a3f35e5 View commit details
    Browse the repository at this point in the history

  4. Fix indentation and add swal for error

    @driusan
    driusan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    db94d5e View commit details
    Browse the repository at this point in the history

  5. Catch all JSON parse errors

    @driusan
    driusan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4c64bf3 View commit details
    Browse the repository at this point in the history

  6. Null coalesce for EDC

    @driusan
    driusan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    404a1c5 View commit details
    Browse the repository at this point in the history