[instrument_builder] ADDED: field warnings for maximum length in Instrument Builder module

[satvik-tha-god]

…t Builder

Brief summary of changes

• Added field warnings for length for _status fields:
• Added field warnings for length for all the fields
• Minor spelling mistake fix

Testing instructions (if applicable)

1. Go to /instrument_builder/#Build
2. Check for warnings for input length greater than 57 for the following fields by clicking Add Row
   1. Data entry->Textbox->Question Name
   2. Data entry->Textarea->Question Name
   3. Data entry->Date->Question Name
   4. Data entry->Numeric->Question Name
3. Check for warnings for input length greater than 64 for the rest of the Question Name and Question Text fields by clicking Add Row

Link(s) to related issue(s)

• Resolves [InstrBuilder] check and warn if fieldname is too long (including _status fields) #7582

[christinerogers]

Great stuff, Satvik! It would be great to have an idea of how the warnings will appear to the end user - could you kindly post a screenshot in this thread, showing the error message in context? Thanks, that would be really helpful in speeding this through the review process.

[satvik-tha-god]

Great stuff, Satvik! It would be great to have an idea of how the warnings will appear to the end user - could you kindly post a screenshot in this thread, showing the error message in context? Thanks, that would be really helpful in speeding this through the review process.

@christinerogers Thanks! Here are the screenshots

[christinerogers]

Hi @satvik-tha-god thanks for this PR!
I've suggested edits for the error messages to let the user know directly what they should do (shorten it). Thanks Satvik for checking over the numbers I included.
@racostas - over to you to check if this satisfies the issue / all cases etc.

[racostas]

Hi @satvik-tha-god,
Great work !!
Please address @christinerogers comments.
The unit test are falling due to code standard nonconformity. You will be able to identify the error entering in the failed test and searching for the error keyword in the output. For this case are simple ones. I attach a screenshot for reference.

[racostas]

Hi @satvik-tha-god,

Two minor changes:

1. The label of the question don't have to be restricted to 64 characters, just the field_name.
2. You will find a test Plan on the module folder. Please let update it accordingly with this new feature to be tested.

[racostas]

Not sure why but it seems some of the test got cancelled.

Please relaunch the jobs.

[racostas]

failing a the test suit, nevertheless I don't see direct relation avec this PR itself. What do you think @driusan ?

[christinerogers]

LGTM. 👍

[christinerogers]

@racostas it looks like this is in your court to re-review, unless i'm reading it wrong?

[racostas]

Thank you @satvik-tha-god for those fixes.
I think the only thing missing is to update the modules/instrument_builder/test/TestPlan.md accordingly. Could you please take a look into it when you get a chance ?
I'm cc @christinerogers as she might want to take a look as well since she identified the original issue.

[driusan]

I think we can merge this and then send another PR to fix the test plan.