Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[instrument_builder] Updates Test Plan according to changes introduced by PR#8112. #8281

Merged
merged 1 commit into from
Dec 16, 2022
Merged

[instrument_builder] Updates Test Plan according to changes introduced by PR#8112. #8281

merged 1 commit into from
Dec 16, 2022

Conversation

racostas
Copy link
Contributor

Brief summary of changes

This is a Test Plan updates for the Instrument Builder module after changes introduced by PR #8112

  • [x ] Have you updated related documentation?

Testing instructions (if applicable)

  1. The Test Plan now should reflect the changes introduced by the PR [instrument_builder] ADDED: field warnings for maximum length in Instrument Builder module #8112 addressing the issue [InstrBuilder] check and warn if fieldname is too long (including _status fields) #7582

Link(s) to related issue(s)

@racostas racostas added the Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs) label Dec 16, 2022
@racostas
Copy link
Contributor Author

image

@racostas racostas added "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help and removed "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help labels Dec 16, 2022
christinerogers
christinerogers approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @racostas - looks good to me

@driusan driusan merged commit d2a1566 into aces:main Dec 16, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@christinerogers christinerogers christinerogers approved these changes

Assignees
No one assigned
Labels
Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs)
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.

Instrument Builder Test Plan needs update
4 participants
@racostas @christinerogers @driusan @ridz1208