[Performance] Do not load module logger from constructor #8200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to solve the speed issues with demo-24.loris.ca. In LORIS 23, there was no LORISInstance object that was used for getting active modules, nor was there a logger instantiated from the constructor. The added overhead of retrieving the log settings for every module instantiation and LorisInstance->getActiveModules instantiating every module is adding up to a lot of overhead in the critical path on demo-24.loris.ca. This moves the logger instantiation to be done after the Module::factory call in the router instead of in the constructor. The result is that it's only done once, instead of done n times (where n is the number of modules.) This doesn't get demo-24.loris.ca up to the speed of demo.loris.ca, but it's significantly closer. It's not clear why this performance regression is only happening on demo and not in other environments.
maltheism
approved these changes
Oct 31, 2022
maltheism
added
the
Passed Manual Tests
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve the speed issues with demo-24.loris.ca.
In LORIS 23, there was no LORISInstance object that was used for getting active modules, nor was there a logger instantiated from the constructor. The added overhead of retrieving the log settings for every module instantiation and LorisInstance->getActiveModules instantiating every module is adding up to a lot of overhead in the critical path on demo-24.loris.ca.
This moves the logger instantiation to be done after the Module::factory call in the router instead of in the constructor. The result is that it's only done once, instead of done n times (where n is the number of modules.)
This doesn't get demo-24.loris.ca up to the speed of demo.loris.ca, but it's significantly closer.
It's not clear why this performance regression is only happening on demo and not in other environments.