Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Annotations #8234

Closed
wants to merge 3 commits into from
Closed

Annotations #8234

wants to merge 3 commits into from

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Nov 22, 2022 •
edited
Loading

  • includes the missing piece for the [EEGBrowser] annotation features to work
  • fix a glitch with clippath
  • truncate the epoch timing values

@christinerogers
Copy link
Contributor

christinerogers commented Nov 22, 2022 •
edited
Loading

this partially does what Jess Callegaro's PR to Main did: #7829 and #7828
HBCD needs this version, so we will have reconcile at some point, or close/re-implement the work on EEGNet.

@laemtl laemtl added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Nov 22, 2022
@laemtl laemtl closed this Nov 23, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laemtl @christinerogers