Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[EEG Browser] Add ability to view annotations in event panel and overlaid on signal viewer #7828

Closed

Conversation

jesscall
Copy link
Contributor

Brief summary of changes

Disclaimer: This PR is blocked by #7811 and will need to be rebased after its merge.

The changes in this PR fill in a few gaps in the code and allow for annotation data to be viewed in the EEG Browser. Annotations are displayed in orange in the Events / Annotation Panel and when selected are shown as an overlay in the signal viewer.

Screen Shot 2021-11-12 at 1 27 09 PM

Testing instructions (if applicable)

  1. Reach out to @jesscall on slack to get access to annotation data / SQL patches
  2. Insert the SQL into your DB and place the files on your VM.
  3. Navigate to the EEG Browser
  4. Make sure that you can see and interact with annotations data.

@jesscall jesscall added Feature PR or issue introducing/requiring at least one new feature Blocked PR awaiting the merge, resolution or rejection of an other Pull Request labels Nov 12, 2021
@christinerogers
Copy link
Contributor

For clarification - does this commit Laetitia's atlas code to main, or is it your new fixes on top of that ?

@jesscall
Copy link
Contributor Author

@christinerogers

Laetitia's ATLAS code fetches the annotations data from the annotation.tsv file.

Since @AlexandraLivadas 's PR #7433 was merged adding back-end structure for annotations, I implemented a solution that gets the info from the DB tables rather than reading from the tsv file.

TLDR; The code in this PR is inspired by ATLAS code, but has a different implementation.

Hope that's clear?

@jesscall
Copy link
Contributor Author

@christinerogers Also for clarification: adding new annotations via front-end is not part of this PR. There are still gaps in the code. PR for that coming soon.

@jesscall jesscall force-pushed the 2021_11_12_add_front_end_annotation_support branch from 7d89277 to a55c31d Compare November 16, 2021 18:27
@jesscall jesscall removed the Blocked PR awaiting the merge, resolution or rejection of an other Pull Request label Nov 16, 2021
@jesscall
Copy link
Contributor Author

rebased, no longer blocked

@laemtl
Copy link
Contributor

laemtl commented Nov 22, 2022

Replaced by #8235

driusan pushed a commit that referenced this pull request Nov 24, 2022
…laid on signal viewer (#8235)

The changes in this PR fill in a few gaps in the code and allow for annotation data to be viewed in the EEG Browser. Annotations are displayed in orange in the Events / Annotation Panel and when selected are shown as an overlay in the signal viewer.

Replaces #7828
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature PR or issue introducing/requiring at least one new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants