[EEG Browser] Annotations: Add new and HED tags #8236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
added
the
Blocked
laemtl
force-pushed
the
2021_11_12_support_for_adding_new_annotations_from_EEG_browser
branch
from
8d8fc51
to
1ff23f4
Compare
laemtl
removed
the
Blocked
laemtl
force-pushed
the
2021_11_12_support_for_adding_new_annotations_from_EEG_browser
branch
from
1ff23f4
to
5063dda
Compare
laemtl
force-pushed
the
2021_11_12_support_for_adding_new_annotations_from_EEG_browser
branch
2 times, most recently
from
923efdd
to
5130d0c
Compare
laemtl
changed the title
laemtl
force-pushed
the
2021_11_12_support_for_adding_new_annotations_from_EEG_browser
branch
3 times, most recently
from
43ac725
to
cbf5d67
Compare
laemtl
changed the title
laemtl
force-pushed
the
2021_11_12_support_for_adding_new_annotations_from_EEG_browser
branch
from
cbf5d67
to
9f75ebe
Compare
maltheism
reviewed
Nov 25, 2022
| $db = $factory->database(); | ||
| $factory = \NDB_Factory::singleton(); | ||
| $user = $factory->user(); | ||
| $db = $factory->database(); |
There was a problem hiding this comment.
Hi @laemtl you could do the following instead of initializing the factory.
$user = $request->getAttribute('user');
$db = $request->getAttribute("loris")->getDatabaseConnection();
I am working on a separate PR that will enable ESLint and fix all those issues. It would be easier since I have one PR based on that one that I would like to rebase. |
laemtl
added
the
Blocking
maltheism
approved these changes
Nov 30, 2022
christinerogers
added
Add to Release Notes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #7829 including custom code from the EEGNet repo to date