-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[imaging browser] Fix Human dangling out of nowhere #8363
[imaging browser] Fix Human dangling out of nowhere #8363
Conversation
@driusan @ridz1208 I sent this to 24.1-release as this corrects a bug that was introduced in LORIS 24. The one with "Human" under T1W QC. I noticed that on HBCD last week and the same week @thomasbeaudry updated his LORIS instance to 24 and noticed it as well. So this should probably go in the next bug fix. |
modules/imaging_browser/php/imagingbrowserrowprovisioner.class.inc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't see anything wrong with the code. Pulled the branch on my VM and tested: works perfectly. Approving. 👍
When downloading the imaging browser list data as CSV, there are dangling "Human"s in a column with no header associated to it. Resolves aces#7876.
Brief summary of changes
This resolves #7876.
When downloading the imaging browser list data as CSV, there are dangling "Human"s with no header associated to it as can be seen below:
This PR corrects the issue so that the Human's have a proper header. It also resolves the Human being placed under T1 QC status for example when no scan types are selected to be displayed in the Config module under the Imaging Module tab. See screenshot below for the bug that was introduced in 24:
In addition, there is currently a bug with the order of the QC status displayed in the imaging browser and the headers in the table. This PR also fix the bug.
As for the content of the CSV showing more columns than what is being displayed, this is a LORIS wide behaviour, not an actual bug.