[new_profile] Site not selected when recruiting another candidate #9197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbrossard
added
Testing
jeffersoncasimir
requested changes
Apr 11, 2024
| // on whether the user clicked on 'Access Profile' or | ||
| // 'Recruit another candidate' respectively | ||
| window.location.href = result.value === true | ||
| ? window.location.href = '/' + data.CandID |
There was a problem hiding this comment.
Suggested change
| ? window.location.href = '/' + data.CandID | |
| ? '/' + data.CandID |
There was a problem hiding this comment.
@jeffersoncasimir You're absolutely right! The funny thing is, the code works, but your version is cleaner/simpler. Ready for another review.
jeffersoncasimir
added
the
Passed Manual Tests
jeffersoncasimir
approved these changes
Apr 11, 2024
|
Works as expected! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that if a user is associated to only one site and creates two candidates in a row, his/her site will be automatically selected on the new profile form when the form is first displayed and when he/she clicks on 'Recruit another candidate'. It also updates the module's test plan to cover this scenario.
Fixes #9146