Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[new_profile] Site not selected when recruiting another candidate #9197

Merged
merged 2 commits into from
Apr 11, 2024
Merged

[new_profile] Site not selected when recruiting another candidate #9197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e67fd
[new_profile] Site not selected when recruiting another candidate
nicolasbrossard Apr 5, 2024
9bd1e44
Jefferson's suggestions
nicolasbrossard Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions modules/new_profile/jsx/NewProfileIndex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,12 @@ class NewProfileIndex extends React.Component {
cancelButtonColor: '#3085d6',
cancelButtonText: 'Recruit another candidate',
}).then((result) => {
if (result.value === true) {
window.location.href = '/' + data.CandID;
} else {
this.setState({
formData: {},
submitDisabled: false,
});
}
// Go to the candidate profile or reload the page, depending
// on whether the user clicked on 'Access Profile' or
// 'Recruit another candidate' respectively
window.location.href = result.value === true
? '/' + data.CandID
: window.location.href;
});
} )
.catch((error) => {
Expand Down
1 change: 1 addition & 0 deletions modules/new_profile/test/TestPlan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ have the current day as the maximum possible value to choose.
10. Change date format from 'YMd' to 'YM' in the Configuration module
and repeat steps 4 to 6 while asserting that database values being
saved are correct.
11. As a user with only one site affiliation, fill the form with valid values and create a new user. When the popup indicating that the creation succeeded is displayed, click on 'Recruit another candidate'. Ensure that when the page reloads, the user's (unique) site is selected.
[Manual Testing]
Loading