Add make_dirs and construct_data_paths to sink.cpp #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
changed the title
aliddell
force-pushed
the
common-construct-data-paths
branch
from
6b4ec7f to
d072255
Compare
aliddell
force-pushed
the
common-construct-data-paths
branch
from
d072255 to
f034d62
Compare
Merged
nclack
approved these changes
Jan 31, 2025
|
|
||
| latch.count_down(); | ||
| all_successful.fetch_and(static_cast<char>(success)); |
There was a problem hiding this comment.
fwiw, you can use release memory ordering here and acquire on the final read.
The default (cst) should work fine and I would be surprised if it mattered for performance.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving away from the
SinkCreatorclass. Depends on #45.