Deprecate SinkCreator
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andalone function make_s3_sink.
aliddell
force-pushed
the
create-sinks-as-functions
branch
from
06250fa to
203bf50
Compare
jeskesen
approved these changes
Feb 5, 2025
| std::shared_ptr<zarr::S3ConnectionPool> connection_pool, | ||
| std::vector<std::unique_ptr<zarr::Sink>>& sinks) | ||
| { | ||
| if (object_keys.empty()) { |
There was a problem hiding this comment.
Is this check necessary? The for loop will just be skipped at the bottom. Is it so the other error checks get skipped if you passed in an empty vector?
| std::shared_ptr<zarr::S3ConnectionPool> connection_pool, | ||
| std::unordered_map<std::string, std::unique_ptr<zarr::Sink>>& sinks) | ||
| { | ||
| if (object_keys.empty()) { |
| @@ -17,8 +17,8 @@ set(tests | |||
| file-sink-write | |||
| s3-sink-write | |||
| s3-sink-write-multipart | |||
| sink-creator-make-metadata-sinks | |||
There was a problem hiding this comment.
should sink-creator-* files get removed?
There was a problem hiding this comment.
They got renamed s/sink-creator-//g.
| sink-creator-make-metadata-sinks | ||
| sink-creator-make-data-sinks | ||
| make-data-sinks | ||
| make-metadata-sinks |
There was a problem hiding this comment.
There are 2 new common-* that have not been added to CMakeLists.txt file. Intentional?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paving the way for writing to non-
Sinkclasses. Depends on #47.